libv4l: disable building Qt #67134
Merged
libv4l: disable building Qt #67134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
requested review from
alyssais,
FRidh,
LnL7,
matthewbauer,
Mic92,
Profpatsch,
ttuegel and
zimbatm
as code owners
jtojnar
removed request for
zimbatm,
matthewbauer,
Mic92,
LnL7,
FRidh,
alyssais and
Profpatsch
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: GNOME
ofborg
bot
removed
6.topic: haskell
6.topic: lua
6.topic: nixos
6.topic: pantheon
|
Hmm, this is an interesting topic. When there's optional qt features I'd expect people to add |
jtojnar
changed the title
jtojnar
force-pushed
the
origin/staging
branch
from
c765bd6
to
b7f6873
Compare
worldofpeace
suggested changes
Aug 21, 2019
Since we added wrapQTAppHooks to qt5.mkDerivation, it pollutes the closure of everything it touches even when package is not building with Qt support. We had to revert to the standard deriver to avoid this.
jtojnar
force-pushed
the
origin/staging
branch
from
b7f6873
to
565a1c8
Compare
worldofpeace
approved these changes
Aug 21, 2019
|
Huh, this is only 101-500 rebuilds according to ofborg. Should we go to master? |
|
There would be a merge conflict. |
|
Ah, merging then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added wrapQTAppHooks to qt5.mkDerivation, it pollutes the closure of everything it touches even when package is not building with QT support.