Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

michabo: init at 0.1 #63330

Merged
merged 1 commit into from Sep 5, 2019
Merged

michabo: init at 0.1 #63330

merged 1 commit into from Sep 5, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jun 17, 2019 •
edited

Motivation for this change

A native pleroma/mastodon client: https://git.pleroma.social/kaniini/michabo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

There's no application icon, as adding it breaks all the in-app icons, as those need to be properly installed too since they use the same filename prefix. I might add it later if it does not get fixed upstream

@fgaz
Copy link
Member Author

fgaz commented Aug 18, 2019

Pointed out the installation during build here.

Is it a blocker for merging this? Anything else?

aanderse
aanderse requested changes Aug 31, 2019
View reviewed changes
pkgs/applications/misc/michabo/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/michabo/default.nix Outdated Show resolved Hide resolved
@fgaz fgaz mentioned this pull request Sep 5, 2019
Merged
10 tasks
@aanderse
Copy link
Member

aanderse commented Sep 5, 2019

@petabyteboy @ashkitten @alyssais as users of mastodon do any of you have interest in giving this a quick test?

@ghost
Copy link

ghost commented Sep 5, 2019

I can confirm it works 👍
screenshot

aanderse
aanderse approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fgaz and @petabyteboy! 🎉

@aanderse aanderse merged commit 36abb06 into NixOS:master Sep 5, 2019
@fgaz fgaz deleted the michabo/init-for-real branch September 5, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @aanderse @jtojnar