Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zziplib: CVE-2018-17828 #63190

Closed
wants to merge 1 commit into from
Closed

zziplib: CVE-2018-17828 #63190

wants to merge 1 commit into from

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jun 16, 2019

(cherry picked from commit f0d386a)

Motivation for this change

Fixes #61961.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
zziplib: CVE-2018-17828
63fb7d3 
(cherry picked from commit f0d386a)
@FRidh
Copy link
Member

FRidh commented Jun 16, 2019 •
edited

This reference will be incorrect. Please cherry-pick after it has been merged into master.

(actually, only correct when doing a rebase, which is what I typically do)

vcunat pushed a commit that referenced this pull request Jun 16, 2019
@mmahut @vcunat
zziplib: patch CVE-2018-17828
152d76d 
Fixes #61961
Close #63190
vcunat amended some nitpicks into the original commit.

(cherry picked from commit 3aa8f94)
@vcunat
Copy link
Member

vcunat commented Jun 16, 2019

Not necessarily, if merging was used, but I decided to amend some problems in the commit directly. Picked as 152d76d.

@vcunat vcunat closed this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @FRidh @vcunat