Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.azure-devops: init at 5.0.0b8 #63187

Closed
wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Follow up to #63184

This is the "new" azure-devops package after vsts was rebranded to azure-devops.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/j2xpynp8kxi476vk0rz0q89sqa1cn9wm-python3.6-azure-devops-5.0.0b8 126.1M

@jonringer jonringer requested a review from FRidh as a code owner June 16, 2019 07:00
}:

buildPythonPackage rec {
version = "5.0.0b8";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we typically don't include beta versions

Copy link
Contributor Author

@jonringer jonringer Jun 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair, this package isn't needed by azure-cli, so I'm okay with skipping it until a stable release.


# Tests are highly impure
checkPhase = ''
python -c 'import azure.devops.version; print(azure.devops.version.VERSION)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${python.interpreter}

@FRidh
Copy link
Member

FRidh commented Jun 16, 2019

By the way, please group related commits in a single PR.

@jonringer
Copy link
Contributor Author

Closing until stable release

@jonringer jonringer deleted the add_azure_devops branch December 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants