Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fswatch: Enable FSEvents API on Darwin #63333

Merged
merged 1 commit into from Jun 18, 2019

Conversation

knl
Copy link
Contributor

@knl knl commented Jun 17, 2019

On Darwin we can benefit from FSEvents API (that fswatch supports) in order to
have better monitoring of file system changes.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

On Darwin we can benefit from FSEvents API (that fswatch supports) in order to
have better monitoring of file system changes.
@basvandijk
Copy link
Member

@GrahamcOfBorg build fswatch

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 17, 2019
@basvandijk basvandijk self-requested a review June 17, 2019 14:16
@basvandijk
Copy link
Member

fswatch builds on my Mac and works correctly.

@basvandijk
Copy link
Member

Do note that a sandboxed build on Mac fails:

nix-build -A fswatch --option sandbox true
...
checking for C++ compiler version... configure: error: in `/private/tmp/nix-build-fswatch-1.14.0.drv-0/source':
configure: error: _AX_COMPILER_VERSION_CLANG unknown clang major
See `config.log' for more details
builder for '/nix/store/yas27asmbd4r7pnswpvl9mawpqqwh64g-fswatch-1.14.0.drv' failed with exit code 1
error: build of '/nix/store/yas27asmbd4r7pnswpvl9mawpqqwh64g-fswatch-1.14.0.drv' failed

@basvandijk
Copy link
Member

Although a sandboxed build fails on Mac, a sandboxed build on master also fails. So we're not worse off.

@basvandijk basvandijk merged commit ad96121 into NixOS:master Jun 18, 2019
@knl knl deleted the enable-fsevents-api-for-fswatch branch June 18, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants