Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder functions #2205

Merged
merged 6 commits into from
Jun 16, 2019
Merged

Reorder functions #2205

merged 6 commits into from
Jun 16, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jun 16, 2019

  • Auxiliary functions appear first in the .cpp file and are in an unnamed namespace.
  • Elk was moved to elliptic_integrals.{hpp,cpp} because, well, it's an integral (and a Cervidae).

Note to the reviewer: only review 745f0f1, this is diffbased off of ThreadHostile.

pleroy added 4 commits June 15, 2019 22:29
… files and are in an unnamed namespace. Move Elk to elliptic_integrals.{hpp,cpp} because, well, it's an integral.
@eggrobin eggrobin added the LGTM label Jun 16, 2019
@pleroy pleroy merged commit b456912 into mockingbirdnest:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants