Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add polybarFull to all-packages #63193

Merged
merged 1 commit into from Jul 7, 2019
Merged

add polybarFull to all-packages #63193

merged 1 commit into from Jul 7, 2019

Conversation

justinwoo
Copy link
Member

Motivation for this change

It would be very nice if I did not have to compile polybar on my machine :))

I could not find any existing discussion about this searching via "Polybar i3"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@justinwoo justinwoo changed the title add polybar with i3 gaps and pulse add polybar with i3 support and pulse Jun 16, 2019
@domenkozar
Copy link
Member

Convention is polybarFull with all the options on.

@justinwoo
Copy link
Member Author

Not entirely sure if that will build, but let's see if it does. That might be fine.

@justinwoo justinwoo changed the title add polybar with i3 support and pulse add polybarFull to all-packages Jul 7, 2019
@justinwoo
Copy link
Member Author

Looks like this ran fine.

@domenkozar domenkozar merged commit 37ee471 into NixOS:master Jul 7, 2019
@justinwoo
Copy link
Member Author

Thanks!

@justinwoo justinwoo deleted the polybar-i3-pulse branch July 8, 2019 12:11
@justinwoo justinwoo mentioned this pull request Jul 8, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinwoo @domenkozar