Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libfsm: init at 0.1pre1869_f70c3c5 #63229

Merged
merged 1 commit into from Jun 16, 2019
Merged

libfsm: init at 0.1pre1869_f70c3c5 #63229

merged 1 commit into from Jun 16, 2019

Conversation

thoughtpolice
Copy link
Member

Signed-off-by: Austin Seipp as@fastly.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thoughtpolice thoughtpolice self-assigned this Jun 16, 2019
libfsm: init at 0.1pre1869_f70c3c5
6472eee 
Signed-off-by: Austin Seipp <as@fastly.com>
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build libfsm

@jameysharp
Copy link
Contributor

Oh, nice! I should have made a pull request for the local recipe I wrote a while back, but I think you've covered everything I had, as well as stuff I missed. Just in case, though, here's what I was using:

with import <nixpkgs> {};

let
  # local bmake recipe elided, I'll post that in a separate issue
in stdenv.mkDerivation rec {
  name = "libfsm";

  src = fetchFromGitHub {
    owner = "katef";
    repo = "libfsm";
    rev = "caf1a0d664d404b5fe06b77fa8372f3262444c4f";
    fetchSubmodules = true;
    sha256 = "1rabwqy07d1vs0pf1nq5cshcg6ip11yl660cr4hynsaraq47h8gs";
  };

  nativeBuildInputs = [ bmake ];

  buildPhase = "bmake -r";
  installPhase = "bmake PREFIX=$out install";
}

@thoughtpolice thoughtpolice mentioned this pull request Jun 16, 2019
Merged
3 tasks
@thoughtpolice thoughtpolice merged commit e6a0514 into NixOS:master Jun 16, 2019
@thoughtpolice thoughtpolice deleted the nixpkgs/add-libfsm branch June 16, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoughtpolice @jameysharp