Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.CatalystPluginSmartURI: init at 0.041 #63230

Closed
wants to merge 3 commits into from

Conversation

catern
Copy link
Contributor

@catern catern commented Jun 16, 2019

Motivation for this change

This package allows Catalyst web projects to use relative URLs instead of absolute URLs. This is specifically interesting to me for Hydra, because using relative URLs allows using Hydra behind a proxy without extra configuration. I've tested Hydra with this package and it works well.

Once this package has been merged for a while, I'll send PRs to both the Hydra repo and to Nixpkgs to add this package as a dependency.

Pinging @volth for review of Perl, @grahamc and @edolstra for relevance to Hydra

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@catern
Copy link
Contributor Author

catern commented Jul 2, 2019

I think this can be merged, it doesn't directly touch Hydra yet, @volth agree?

@catern
Copy link
Contributor Author

catern commented Jul 2, 2019

Sure, works for me, I can wait likewise for my other perl package PRs

@catern catern changed the title perlPackages.URISmartURI: init at 0.032 perlPackages.CatalystPluginSmartURI: init at 0.041 Aug 9, 2019
@catern
Copy link
Contributor Author

catern commented Aug 9, 2019

Rebased on master. Also updated the title to be more accurate about what package we really want to add

@catern
Copy link
Contributor Author

catern commented Aug 9, 2019

Awesome, thank you! When that merges it will close this PR automatically I believe, so I'll leave it open so that happens.

@aanderse
Copy link
Member

ping (triage)

@aanderse aanderse closed this Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants