Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes: fix kubelet service unit configuration #63197

Closed
wants to merge 2 commits into from
Closed

Kubernetes: fix kubelet service unit configuration #63197

wants to merge 2 commits into from

Conversation

azazel75
Copy link
Contributor

Refactored systemd unit to better handle optional attrs and their
interaction with ""

Motivation for this change

I've got a startup failure of the kubelet when trying master code

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@azazel75
Kubernetes: fix kubelet service unit configuration
eef57fd 
Refactored systemd unit to better handle optional attrs and their
interaction with "\"
@azazel75
Copy link
Contributor Author

cc @srhb @johanot @calbrecht

@azazel75
Kubernetes: fix apiserver service unit
7a80a91 
Refactor the startup script to not show more "\" than necessary
@azazel75
Copy link
Contributor Author

Done the same for apiserver

@kliu128 kliu128 mentioned this pull request Jun 19, 2019
Closed
@srhb
Copy link
Contributor

srhb commented Jun 25, 2019

I've filed systemd/systemd#12883 since this is global breakage for us.

@azazel75
Copy link
Contributor Author

Thanks, @srhb I didn't realize it was a global issue... also, it's good to know that someone reads things like this ;-)

@globin
Copy link
Member

globin commented Aug 1, 2019

Can we close this as it seems to be included in our systemd version?

@azazel75 azazel75 closed this Aug 2, 2019
@azazel75
Copy link
Contributor Author

azazel75 commented Aug 2, 2019

Is it included? I don't think so, but it seems that the issue has been resolved at the systemd level

@srhb
Copy link
Contributor

srhb commented Aug 3, 2019

@azazel75 It is: NixOS/systemd@bcbaa8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azazel75 @srhb @globin