Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop obsolete wayland compositors #63195

Merged
merged 3 commits into from Jul 26, 2019
Merged

Drop obsolete wayland compositors #63195

merged 3 commits into from Jul 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 16, 2019

Motivation for this change
  • pkgs/applications/window-managers/orbment/bemenu.nix

  • This is now replaced by https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/bemenu/default.nix

  • pkgs/applications/window-managers/orbment/default.nix

  • Not updated since 2016

  • pkgs/applications/window-managers/velox/default.nix

  • Not used by anyone but its author, has no active development, all of its components are not compatible with other compositors

  • pkgs/applications/window-managers/velox/dmenu.nix

  • pkgs/applications/window-managers/velox/st.nix

  • pkgs/applications/window-managers/velox/swc.nix

  • pkgs/applications/window-managers/velox/wld.nix

  • pkgs/development/libraries/wlc/default.nix

  • Move to pkgs/applications/window-managers/way-cooler/wlc.nix nothing but way-cooler currently uses it. Once there will be release of way-cooler using wlroots, we will drop wlc.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jun 16, 2019

@primeos What do you think?

Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@primeos
Copy link
Member

primeos commented Jun 16, 2019

cc @tg-x

@primeos primeos mentioned this pull request Jun 16, 2019
@ghost
Copy link
Author

ghost commented Jul 26, 2019

@primeos merge please?

@primeos primeos merged commit 5f9145d into NixOS:master Jul 26, 2019
@primeos
Copy link
Member

primeos commented Jul 26, 2019

@gnidorah sorry, forgot to merge it :o Thanks for the reminder and the PR :)

@ghost
Copy link
Author

ghost commented Jul 27, 2019

@primeos Thank you!

@ghost ghost deleted the wlc branch July 27, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant