Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: describe pname #63196

Merged
merged 1 commit into from Jun 16, 2019
Merged

doc: describe pname #63196

merged 1 commit into from Jun 16, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 16, 2019 •
edited

Motivation for this change

Addresses a common papercut https://discourse.nixos.org/t/the-papercut-thread-post-your-small-annoyances-confusions-here/3100/65?u=jtojnar

This was missed in #49398

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Jun 16, 2019
Merged
10 tasks
@jtojnar
doc: describe pname
eebd61c 
This was forgotten when RFC 0035 was implemented.
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/the-papercut-thread-post-your-small-annoyances-confusions-here/3100/86

@FRidh FRidh merged commit 902952d into NixOS:master Jun 16, 2019
@jtojnar jtojnar deleted the pname-doc branch June 16, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @nixos-discourse @danieldk @FRidh