Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: build on i686-linux #63199

Merged
merged 1 commit into from Jul 1, 2019
Merged

alacritty: build on i686-linux #63199

merged 1 commit into from Jul 1, 2019

Conversation

NilsIrl
Copy link
Member

@NilsIrl NilsIrl commented Jun 16, 2019 •
edited

Motivation for this change

Being able to run alacritty on a 32bit machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 June 16, 2019 11:10
@danbst danbst merged commit 58f7155 into NixOS:master Jul 1, 2019
@Mic92
Copy link
Member

Mic92 commented Jul 1, 2019 •
edited

Might be fair to backport this as well if requested.

Mic92
Mic92 reviewed Jul 1, 2019
View reviewed changes
pkgs/applications/misc/alacritty/default.nix
@@ -119,6 +119,6 @@ in buildRustPackage rec {
homepage = https://github.com/jwilm/alacritty;
license = with licenses; [ asl20 ];
maintainers = with maintainers; [ mic92 ];
platforms = [ "x86_64-linux" "x86_64-darwin" "aarch64-linux" ];
platforms = [ "x86_64-linux" "i686-linux" "x86_64-darwin" "aarch64-linux" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be generalized to

platforms = lib.platforms.linux ++ lib.platforms.darwin;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm... I don't understand. lib.platforms is different in release-19.03 and master. Why that?
release-19.03

    # back-compat aliases
    platforms = systems.forMeta;

master

    # back-compat aliases
    platforms = systems.doubles;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, gotcha, there were some hacks removed in master

@Mic92 yup, that may work as well.

danbst pushed a commit that referenced this pull request Jul 1, 2019
@NilsIrl @danbst
alacritty: build on i686-linux, aarch64-linux (#63199, #61933)
e0c7712
@NilsIrl NilsIrl deleted the alacritty-32bit branch July 13, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@danbst danbst danbst left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NilsIrl @Mic92 @danbst