Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: 2.2 -> 2.3 #63349

Merged
merged 2 commits into from Jun 18, 2019
Merged

nix-prefetch-github: 2.2 -> 2.3 #63349

merged 2 commits into from Jun 18, 2019

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Jun 17, 2019 •
edited

Motivation for this change

The software had a new release upstream. This PR updates the nix-prefetch-github in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

worldofpeace
worldofpeace suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like you need requests anymore seppeljordan/nix-prefetch-github@199e981

@seppeljordan
nix-prefetch-github: Remove propagatedBuildInputs `requests'
08dbc60 
`requests' is no longer required per setup.cfg
@seppeljordan
Copy link
Contributor Author

@worldofpeace Thanks for catching that. I made a new commit explaining the change and I also tested the resulting executables on my machine. If you want me to squash those commits and force push, let me know.

worldofpeace
worldofpeace approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

@worldofpeace worldofpeace merged commit 6fa7263 into NixOS:master Jun 18, 2019
@worldofpeace
Copy link
Contributor

Thanks you @seppeljordan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @worldofpeace @mmahut