Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skopeo: 0.1.36 -> 0.1.37 #63352

Merged
merged 1 commit into from Aug 3, 2019
Merged

skopeo: 0.1.36 -> 0.1.37 #63352

merged 1 commit into from Aug 3, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jun 17, 2019 •
edited

Motivation for this change

Bump to latest release of skopeo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
skopeo: 0.1.36 -> 0.1.37
19946b0 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@GrahamcOfBorg build skopeo

@vdemeester
Copy link
Member Author

@GrahamcOfBorg test docker-tools

mmahut
mmahut reviewed Jun 17, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the test failed, but:

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@vdemeester
Copy link
Member Author

ping @lewo @offlinehacker

NeQuissimus
NeQuissimus approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@NeQuissimus NeQuissimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skopeo works, I do get the same test failure locally though

srhb
srhb requested changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting in a red review to avoid accidental merges while trying to figure out the test failure. I think it's critical enough.

srhb
srhb approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, rebasing on top of master actually removes the error. Phew! 😁

@srhb srhb merged commit c99d704 into NixOS:master Aug 3, 2019
@vdemeester vdemeester deleted the update-skopeo branch August 3, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@srhb srhb srhb approved these changes

@offlinehacker offlinehacker offlinehacker approved these changes

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vdemeester @mmahut @srhb @offlinehacker @NeQuissimus