Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libelf: Add patch to prevent -Wundef warnings. #63166

Merged
merged 1 commit into from Jun 24, 2019
Merged

libelf: Add patch to prevent -Wundef warnings. #63166

merged 1 commit into from Jun 24, 2019

Conversation

ambrop72
Copy link
Contributor

The Linux kernel includes libelf headers with -Wundef and -Werror enabled, resulting in an error when the headers are found through -I as opposed to -isystem.

Fixes #59929

Things done

Tested doing the things in the linked issue and confirmed the issue is gone with this patch. Note that this included a rebuild of various things including gcc.

Note that the libelf upstream site is dead.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ambrop72
libelf: Add patch to prevent -Wundef warnings.
213be07 
The Linux kernel includes libelf headers with -Wundef and -Werror enabled, resulting in an error when the headers are found through -I as opposed to -isystem.

Fixes NixOS#59929
@ambrop72
Copy link
Contributor Author

Note that the new code is not 100% equivalent (it has different meaning when the macro is defined to 0), but these macros are either defined to 1 or undefined by a generated header, so it does not matter.

@FRidh FRidh changed the base branch from master to staging June 18, 2019 09:17
@FRidh
Copy link
Member

FRidh commented Jun 18, 2019

Waiting for reviews before merging into staging.

@matthewbauer matthewbauer merged commit f9b7348 into NixOS:staging Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ambrop72 @FRidh @matthewbauer