Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xastir: 2.1.0 -> 2.1.2 #63167

Merged
merged 1 commit into from Jun 24, 2019
Merged

xastir: 2.1.0 -> 2.1.2 #63167

merged 1 commit into from Jun 24, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 15, 2019

Version 2.1.2 is compatible with recent versions of proj (see #63134)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
xastir: 2.1.0 -> 2.1.2
2b410b9 
Version 2.1.2 is compatible with recent versions of proj
mmahut
mmahut approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@vbgl vbgl merged commit 2307ac9 into NixOS:master Jun 24, 2019
@vbgl vbgl deleted the xastir-2.1.2 branch June 24, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @mmahut