Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hdbscan: fix build by applying upstream patch #63232

Merged
merged 1 commit into from Jun 16, 2019
Merged

pythonPackages.hdbscan: fix build by applying upstream patch #63232

merged 1 commit into from Jun 16, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 16, 2019

Motivation for this change

Simple missing import in one of the test modules

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner June 16, 2019 18:37
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python27Packages.hdbscan python35Packages.hdbscan python36Packages.hdbscan
python37Packages.hdbscan

@risicle
pythonPackages.hdbscan: fix build by applying upstream patch
2be7ccf 
simple missing import in one of the test modules
@worldofpeace worldofpeace merged commit 9e84b40 into NixOS:master Jun 16, 2019
@worldofpeace
Copy link
Contributor

Thanks @risicle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @worldofpeace