Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyo3-pack: 0.5.0 -> 0.6.1 #63321

Merged
merged 1 commit into from Jul 8, 2019
Merged

pyo3-pack: 0.5.0 -> 0.6.1 #63321

merged 1 commit into from Jul 8, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changes:

  • Basic PyPy support.
  • Removes Python 2 support.
  • Removes custom progress bar.

https://github.com/PyO3/pyo3-pack/releases/tag/v0.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
pyo3-pack: 0.5.0 -> 0.6.1
2cc2ccd 
Changes:

- Basic PyPy support.
- Removes Python 2 support.
- Removes custom progress bar.

https://github.com/PyO3/pyo3-pack/releases/tag/v0.6.0
@danieldk
Copy link
Contributor Author

@GrahamcOfBorg build pyo3-pack

matthiasbeyer
matthiasbeyer approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

jonringer
jonringer approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review pr 63321 passed
diff LGTM

$ nix-review pr 63321
....
[4 built, 9 copied (302.3 MiB), 99.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/63321
1 package were build:
pyo3-pack

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/23

@worldofpeace worldofpeace merged commit 9cc8f88 into NixOS:master Jul 8, 2019
@danieldk danieldk deleted the pyo3-pack-0.6.1 branch July 6, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danieldk @nixos-discourse @matthiasbeyer @jonringer @worldofpeace