Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.plat: dedent overrides. #105

Merged
merged 1 commit into from Jun 16, 2019
Merged

build.plat: dedent overrides. #105

merged 1 commit into from Jun 16, 2019

Conversation

peteut
Copy link
Contributor

@peteut peteut commented Jun 16, 2019

TemplatedPlatform.toolchain_prepare should probably dedent overrides well.

@codecov
Copy link

codecov bot commented Jun 16, 2019 •
edited

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files          32       32           
  Lines        4998     4998           
  Branches     1075     1075           
=======================================
  Hits         4034     4034           
  Misses        830      830           
  Partials      134      134
Impacted Files Coverage Δ
nmigen/build/plat.py 23.6% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70bbfec...ecf673d. Read the comment docs.

@whitequark
Copy link
Contributor

Hm, I guess that's harmless and useful.

@whitequark whitequark merged commit 04c0771 into m-labs:master Jun 16, 2019
@peteut peteut deleted the upstream-master branch June 27, 2019 19:05
@nmigen-issue-migration nmigen-issue-migration mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peteut @whitequark