-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: CVE-2019-5435 #63203
curl: CVE-2019-5435 #63203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this 👍!
We are trying to not add that many patches into nixpkgs unless really required. Patches should rather be fetched using a suitable fetcher (pkgs.fetchpatch
, pkgs.fetchurl
, …).
Other then that it looks good. I still have to test-build a few packages regardless of the above comment.
@andir yes, indeed. However
|
See: https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L264-L296 |
Ah, ok. I might be doing something wrong, see: https://gist.github.com/mmahut/5390f0e6ab1528274404b24a0337438c |
I see. That might just be because something int he dependency chain of |
@andir you are right, |
Well, hopefully it will last long enough. The point of using |
Motivation for this change
Fixes #63063.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)