(backport) asciidoctor: 1.5.7.1 -> 2.0.10 #63327
Merged
+63
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build asciidoc |
basvandijk
reviewed
Jun 17, 2019
| @@ -1,9 +1,7 @@ | |||
| source 'https://rubygems.org' | |||
| gem 'asciidoctor' | |||
| gem 'asciidoctor-diagram' | |||
| gem 'asciidoctor-bespoke' | |||
There was a problem hiding this comment.
We generally don't like to remove functionality from release branches. Is there a way to bring this back?
There was a problem hiding this comment.
I created one commit on top, that brings back bespoke. @basvandijk PTAL.
There has been a new major version, so it seems good to upgrade. I had to drop two plugins: - `asciidoctor-latex` seems dead, and hasn't had any commits since 2015. - `asciidoctor-bespoke` also hasn't been updated for over a year, and doesn't seem to be compatible with the new version. (cherry picked from commit 3d1e0da)
knl
force-pushed
the
backport-asciidoctor-upgrade
branch
from
cb3c7b6 to
fc7442d
Compare
|
@GrahamcOfBorg build asciidoc |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original message:
There has been a new major version, so it seems good to upgrade.
I had to drop two plugins:
asciidoctor-latexseems dead, and hasn't had any commits since 2015.asciidoctor-bespokealso hasn't been updated for over a year, anddoesn't seem to be compatible with the new version.
addendum:
asciidoctor-bespokeis back(cherry picked from commit 3d1e0da)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)