Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-mpv: 0.13 -> 0.16 #63179

Merged
merged 1 commit into from Jun 16, 2019
Merged

gnome-mpv: 0.13 -> 0.16 #63179

merged 1 commit into from Jun 16, 2019

Conversation

lightbulbjim
Copy link
Contributor

@lightbulbjim lightbulbjim commented Jun 15, 2019 •
edited

Motivation for this change

Updating to newest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 15, 2019 •
edited

I was just checking this out a few hours ago. No significant changes except the repo rename:

@lightbulbjim
Copy link
Contributor Author

I was just checking this out a few hours ago. No significant changes except the repo rename:

* https://github.com/celluloid-player/celluloid/releases/tag/v0.14

* https://github.com/celluloid-player/celluloid/releases/tag/v0.15

* https://github.com/celluloid-player/celluloid/releases/tag/v0.16

There is a significant bug in 0.13 where the config directory $HOME/.config/gnome-mpv is created with 0600 permissions, preventing saving the video position on exit (Shift + q). See celluloid-player/celluloid@0f3c23f

@jtojnar
Copy link
Contributor

jtojnar commented Jun 16, 2019

Opened upstream PR celluloid-player/celluloid#437

@jtojnar jtojnar changed the title gnome-mpv: 0.13 -> 0.16 Merge pull request #63179 from lightbulbjim/gnome-mpv-update Jun 16, 2019
@jtojnar jtojnar merged commit ca51fbb into NixOS:master Jun 16, 2019
@jtojnar jtojnar changed the title Merge pull request #63179 from lightbulbjim/gnome-mpv-update gnome-mpv: 0.13 -> 0.16 Jun 16, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Jun 16, 2019

GitHub is being weird these days, renaming the PRs.

Anyway, thanks for the patch.

@lightbulbjim lightbulbjim deleted the gnome-mpv-update branch June 16, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lightbulbjim @jtojnar