Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gthumb: 3.6.2 -> 3.8.0 #63180

Merged
merged 1 commit into from Jun 16, 2019
Merged

gthumb: 3.6.2 -> 3.8.0 #63180

merged 1 commit into from Jun 16, 2019

Conversation

worldofpeace
Copy link
Contributor

  • enable clutter-gtk support
    Upstream defaults to it so we probably should as well.
Motivation for this change

Fixes build with exiv2 0.27.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgs/applications/graphics/gthumb/default.nix Outdated Show resolved Hide resolved
glib gtk3 gsettings-desktop-schemas gst_all_1.gstreamer gst_all_1.gst-plugins-base
exiv2 libjpeg libtiff libraw libsoup libsecret libchamplain
librsvg libwebp json-glib webkitgtk lcms2 gnome3.adwaita-icon-theme
clutter-gtk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is fine if upstream does use it. It is not like the library is officially deprecated yet.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 16, 2019

@worldofpeace worldofpeace force-pushed the gthumb/3.8.0 branch 2 times, most recently from 272d447 to 885da1c Compare June 16, 2019 01:59
@worldofpeace
Copy link
Contributor Author

I've

  • corrected license to gpl2Plus
  • re-enabled libchamplain support
  • patchShebangs specifically

* enable clutter-gtk support
  Upstream defaults to it so we probably should as well.
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worldofpeace
Copy link
Contributor Author

Thanks @jtojnar

@worldofpeace worldofpeace merged commit 636f1f0 into NixOS:master Jun 16, 2019
@worldofpeace worldofpeace deleted the gthumb/3.8.0 branch June 16, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants