Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singularity: 3.0.1 -> 3.2.1 #63409

Merged
merged 1 commit into from Jun 20, 2019
Merged

singularity: 3.0.1 -> 3.2.1 #63409

merged 1 commit into from Jun 20, 2019

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Jun 18, 2019

Motivation for this change

Version update, build process has changed slightly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@markuskowa
Copy link
Member

@GrahamcOfBorg build singularity

@markuskowa markuskowa merged commit b8c4769 into NixOS:master Jun 20, 2019
@markuskowa markuskowa mentioned this pull request Jun 20, 2019
Closed
@markuskowa
Copy link
Member

Should this be back-ported to 19.03, given the fact that the old version seems to have a lot of bugs?

@jbedo
Copy link
Contributor Author

jbedo commented Jun 20, 2019 via email

@markuskowa
Copy link
Member

@jbedo If the bugs are severe enough and it does not break anything else or changes behavior a back port could be justified. I am not a singularity user so I would leave that decision the people actively using it.

@jbedo jbedo deleted the singularity branch June 25, 2019 06:50
@jbedo
Copy link
Contributor Author

jbedo commented Jun 25, 2019

OK, I'm not sure the bugs are severe enough to warrant backporting, maybe @bbarker can comment.

@bbarker
Copy link
Contributor

bbarker commented Jun 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbedo @markuskowa @bbarker @mmahut