bazelisk: 0.0.4 -> 0.0.7 #63217

r-ryantm · 2019-06-16T14:26:10Z

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bazelisk/versions.

meta.description for bazelisk is: '"A user-friendly launcher for Bazel"'.

meta.homepage for bazelisk is: '"https://github.com/philwo/bazelisk"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.0.7 with grep in /nix/store/agwgqv2jxrzb417jaqmy20pjicr2siif-bazelisk-0.0.7
directory tree listing: https://gist.github.com/85555cddb35d68a65fe73a23a7eebc78
du listing: https://gist.github.com/7df94338763b8f1f4a302a7289a24752

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
bazelisk

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/agwgqv2jxrzb417jaqmy20pjicr2siif-bazelisk-0.0.7 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A bazelisk https://github.com/r-ryantm/nixpkgs/archive/3d0d64bcbc18e0833bc6b8fcc36dcc188750f305.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/agwgqv2jxrzb417jaqmy20pjicr2siif-bazelisk-0.0.7
ls -la /nix/store/agwgqv2jxrzb417jaqmy20pjicr2siif-bazelisk-0.0.7/bin

cc @elasticdog @kalbasit for testing.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bazelisk/versions

kalbasit · 2019-06-16T16:07:13Z

@mmahut can you please test this out for me? Thx!

mmahut · 2019-06-16T16:14:50Z

@kalbasit sure, sadly this one seems to be broken.

Looks like this is not pure, as it is trying to fetch out.

$ ./bin/bazelisk 
2019/06/16 18:10:52 Downloading https://releases.bazel.build/0.26.1/release/bazel-0.26.1-linux-x86_64...

When running unpure, after building it manually. It errors with :

$ /nix/store/agwgqv2jxrzb417jaqmy20pjicr2siif-bazelisk-0.0.7/bin/bazelisk
2019/06/16 18:13:22 could not run Bazel: could not start Bazel: fork/exec /home/mmahut/.cache/bazelisk/bin/bazel-0.26.1-linux-x86_64: no such file or directory
$ file /home/mmahut/.cache/bazelisk//bin/bazel-0.26.1-linux-x86_64 
/home/mmahut/.cache/bazelisk//bin/bazel-0.26.1-linux-x86_64: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.24, BuildID[sha1]=84c4e45ee5c0442e44ecb9540495bb374d87721e, not stripped
$  ldd /home/mmahut/.cache/bazelisk//bin/bazel-0.26.1-linux-x86_64 |grep "not found"
	libstdc++.so.6 => not found
$

kalbasit · 2019-06-16T19:45:06Z

I remember @elasticdog once said that they uses this package on a different distribution. I'll wait for their review then.

elasticdog · 2019-06-17T23:49:59Z

Confirmed that this works okay for me on macOS, but also that it is unpure:

$ file ~/Library/Caches/bazelisk/bin/bazel-0.27.0-darwin-x86_64
/Users/elasticdog/Library/Caches/bazelisk/bin/bazel-0.27.0-darwin-x86_64: Mach-O 64-bit executable x86_64

$ otool -L ~/Library/Caches/bazelisk/bin/bazel-0.27.0-darwin-x86_64
/Users/elasticdog/Library/Caches/bazelisk/bin/bazel-0.27.0-darwin-x86_64:
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.4)
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1570.15.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.250.1)
        /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1570.15.0)
        /usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)

Looks like we should to tweak things to not link to the system libraries?

marsam · 2019-06-18T11:57:46Z

Looks like we should to tweak things to not link to the system libraries?

bazelisk basically downloads and uses the released binaries from bazel, it doesn't work on NixOS because we don't have the dynamic linker in the same path; but works on darwin and other linux distributions.
I'd merge this PR as is, because tweaking it would be a futile task

mmahut · 2019-06-18T12:47:55Z

I suggest using platforms = platforms.darwin; if we know it is working only on darwin.

kalbasit · 2019-06-18T14:22:41Z

Looks like we should to tweak things to not link to the system libraries?

bazelisk basically downloads and uses the released binaries from bazel, it doesn't work on NixOS because we don't have the dynamic linker in the same path; but works on darwin and other linux distributions.
I'd merge this PR as is, because tweaking it would be a futile task

I'm not sure it's even worth it to go ahead and patch Bazel for NixOS, as we already have bazel built from source. I'll merge the PR as-is since this is just an update. @elasticdog please open an issue so we can discuss this further.

marsam · 2019-06-19T15:53:37Z

please open an issue so we can discuss this further.

I personally don't think it's worth discussing it. Bazelisk works in every other platform, but not NixOS; we can't patch it, nor can't disable it for NixOS.

kalbasit · 2019-06-19T16:08:50Z

Well I'm wondering if it should be in nixpkgs at all, maybe it should be in a NUR?

marsam · 2019-06-19T16:50:08Z

I think the maintainer found useful enough to be part of nixpkgs, also right now nixpkgs bazel only works on linux+darwin, but bazelisk seems to also work on windows.

kalbasit · 2019-06-19T17:27:01Z

Fair enough! @elasticdog please add to the description that this package does not work on NixOS, to avoid confusion.

bazelisk: 0.0.4 -> 0.0.7

3d0d64b

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bazelisk/versions

ofborg bot requested a review from kalbasit June 16, 2019 14:50

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 16, 2019

marsam merged commit cd2cab4 into NixOS:master Jun 19, 2019

r-ryantm deleted the auto-update/bazelisk branch July 1, 2019 03:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bazelisk: 0.0.4 -> 0.0.7 #63217

bazelisk: 0.0.4 -> 0.0.7 #63217

r-ryantm commented Jun 16, 2019

kalbasit commented Jun 16, 2019

mmahut commented Jun 16, 2019

kalbasit commented Jun 16, 2019 •

edited

elasticdog commented Jun 17, 2019

marsam commented Jun 18, 2019

mmahut commented Jun 18, 2019

kalbasit commented Jun 18, 2019 •

edited

marsam commented Jun 19, 2019

kalbasit commented Jun 19, 2019

marsam commented Jun 19, 2019

kalbasit commented Jun 19, 2019

bazelisk: 0.0.4 -> 0.0.7 #63217

bazelisk: 0.0.4 -> 0.0.7 #63217

Conversation

r-ryantm commented Jun 16, 2019

kalbasit commented Jun 16, 2019

mmahut commented Jun 16, 2019

kalbasit commented Jun 16, 2019 • edited

elasticdog commented Jun 17, 2019

marsam commented Jun 18, 2019

mmahut commented Jun 18, 2019

kalbasit commented Jun 18, 2019 • edited

marsam commented Jun 19, 2019

kalbasit commented Jun 19, 2019

marsam commented Jun 19, 2019

kalbasit commented Jun 19, 2019

kalbasit commented Jun 16, 2019 •

edited

kalbasit commented Jun 18, 2019 •

edited