Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mididings: init at 20151117 #63207

Merged
merged 2 commits into from Jul 10, 2019
Merged

mididings: init at 20151117 #63207

merged 2 commits into from Jul 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 16, 2019 •
edited by ghost

Motivation for this change

mididings is a MIDI router and processor based on Python, supporting ALSA and JACK MIDI. It is available under the GNU GPL and currently runs on Linux.

Closes #50898

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from FRidh as a code owner June 16, 2019 13:01
matthiasbeyer
matthiasbeyer approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

FRidh
FRidh reviewed Jun 23, 2019
View reviewed changes
pkgs/tools/audio/mididings/default.nix

preBuild = with stdenv.lib.versions; ''
substituteInPlace setup.py \
--replace boost_python "boost_python${major pythonPackages.python.version}${minor pythonPackages.python.version}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this major and minor?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these functions from stdenv.lib.versions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh @matthiasbeyer They are. imported with with stdenv.lib.versions;
Needed because pythonPackages.boost library is at path lib/libboost_python27.so. Please let me know if there's a better way to find that library

@FRidh
Copy link
Member

FRidh commented Jul 10, 2019

@GrahamcOfBorg build mididings

@FRidh FRidh merged commit c62f181 into NixOS:master Jul 10, 2019
@ghost
Copy link
Author

ghost commented Jul 10, 2019

@FRidh Thank you!

@ghost ghost deleted the mididings branch July 10, 2019 10:49
@ghost ghost mentioned this pull request Feb 16, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @matthiasbeyer