Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome-export: init at 2.0.2 #63371

Merged
merged 1 commit into from Jul 16, 2019
Merged

chrome-export: init at 2.0.2 #63371

merged 1 commit into from Jul 16, 2019

Conversation

bdesham
Copy link
Contributor

@bdesham bdesham commented Jun 17, 2019

Motivation for this change

Adds chrome-export, which converts Chrome’s bookmark and history files to the standard HTML bookmarks file format.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bdesham
Copy link
Contributor Author

bdesham commented Jun 17, 2019

@mmahut Thank you for the review!

@bdesham bdesham force-pushed the master branch 3 times, most recently from 51f9a48 to b20cdce Compare June 18, 2019 02:50
matthiasbeyer
matthiasbeyer requested changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should rather be packaged using mkPythonApplication rather than mkDerivation, I guess...

@bdesham
Copy link
Contributor Author

bdesham commented Jun 19, 2019

@matthiasbeyer I’m not sure why that would be needed in this case. The package does not have a setup.py and does not depend on any Python modules other than those included with the interpreter itself. I don’t see what would be gained by using buildPythonApplication instead of mkDerivation—I would still need to manually install the man pages and specify how to run the tests, and I think I would have to explicitly opt out of some other behaviors that this package doesn’t use.

@bdesham
Copy link
Contributor Author

bdesham commented Jun 26, 2019

Are there any other concerns with this PR or is it good to be merged?

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/27

@infinisil infinisil merged commit 4078909 into NixOS:master Jul 16, 2019
@infinisil
Copy link
Member

Looking good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@jtojnar jtojnar jtojnar left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bdesham @nixos-discourse @infinisil @mmahut @matthiasbeyer @jtojnar