Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theft: 0.4.4 -> 0.4.5, fix pkg-config file #63186

Merged
merged 1 commit into from Jun 16, 2019
Merged

theft: 0.4.4 -> 0.4.5, fix pkg-config file #63186

merged 1 commit into from Jun 16, 2019

Conversation

thoughtpolice
Copy link
Member

The libtheft.pc file was using prefix=/usr/local for its own relative
-L/-l/-I parameters for GCC, giving incorrect results. (This is really
more of an upstream bug.)

This also adds myself to the maintainer list, and enables builds on
non-Linux platforms.

Signed-off-by: Austin Seipp as@fastly.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

theft: 0.4.4 -> 0.4.5, fix pkg-config file
67b29a3 
The libtheft.pc file was using prefix=/usr/local for its own relative
-L/-l/-I parameters for GCC, giving incorrect results. (This is really
more of an upstream bug.)

This also adds myself to the maintainer list, and enables builds on
non-Linux platforms.

Signed-off-by: Austin Seipp <as@fastly.com>
@thoughtpolice thoughtpolice self-assigned this Jun 16, 2019
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build theft

@thoughtpolice thoughtpolice merged commit c683032 into NixOS:master Jun 16, 2019
@thoughtpolice thoughtpolice deleted the nixpkgs/theft-update branch June 16, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thoughtpolice