Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.vsts: init at 0.1.25 #63184

Merged
merged 1 commit into from Jul 15, 2019
Merged

pythonPackages.vsts: init at 0.1.25 #63184

merged 1 commit into from Jul 15, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Another dependency for for the azure-cli package.

This is the final version for the vsts package as it has been rebranded to azure-devops for future development.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/njn49gjkdi0c18x48bd9qnfq22rs755i-python3.6-vsts-0.1.25 125.7M

It is a big boi

@jonringer jonringer requested a review from FRidh as a code owner June 16, 2019 05:10
@flokli
Copy link
Contributor

flokli commented Jun 16, 2019

@jonringer does it still make sense to package this, as it's rebranded to azure-devops?

@jonringer
Copy link
Contributor Author

it does because other packages use this specific version (specifically the azure-cli package). The changes include the namespace change of import vsts -> import azure.devops and they use different versions of the azure devops API (not sure what changes this means for the python bindings).

@flokli
Copy link
Contributor

flokli commented Jun 17, 2019

Hm, I was hoping azure-cli would also update their usage of bindings to import from the new module. But if they currently don', and it's unlikely they do in the near future, adding both seems to be okay IMHO.

@jonringer
Copy link
Contributor Author

I forgot to mention that azure-devops is still unstable, so these are the latest stable bindings.

@FRidh
Copy link
Member

FRidh commented Jun 23, 2019

@GrahamcOfBorg build pythonPackages.vsts python3Packages.vsts

@jonringer
Copy link
Contributor Author

@FRidh verified azure-cli still needs this because azure-functions-devops-build still requires it.

nix-review still passes :)

@FRidh FRidh merged commit 2e1a90e into NixOS:master Jul 15, 2019
@jonringer jonringer deleted the add_vsts branch December 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @flokli @FRidh