Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restya-board's phpfpm.pools option #63339

Merged
merged 1 commit into from Jul 6, 2019
Merged

Fix restya-board's phpfpm.pools option #63339

merged 1 commit into from Jul 6, 2019

Conversation

Slabity
Copy link
Contributor

@Slabity Slabity commented Jun 17, 2019 •
edited

Motivation for this change

It looks like this service was set up to provide phpfpm.pools set, but still used the phpfpm.poolConfigs attribute name.

This changes it so the proper attribute is being modified, fixing #63128

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Slabity Slabity mentioned this pull request Jun 17, 2019
Closed
@infinisil
Copy link
Member

LGTM

@infinisil
Copy link
Member

Can you change the commit message to "nixos/restya-board: Fix phpfpm.pools option"?

@Slabity
Copy link
Contributor Author

Slabity commented Jul 6, 2019

Changed the commit message.

@infinisil infinisil merged commit 944e21c into NixOS:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Slabity @infinisil