Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/cassandra: use cassandra's default cluster name "Test Cluster" #63392

Merged
merged 1 commit into from Jun 25, 2019
Merged

nixos/cassandra: use cassandra's default cluster name "Test Cluster" #63392

merged 1 commit into from Jun 25, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jun 18, 2019

Motivation for this change

The change to make the default cluster name "NixOS Test Cluster" in #59179 broke startup of existing clusters that used the previously-default cluster name "Test Cluster":

ERROR 23:00:47 Fatal exception during initialization
org.apache.cassandra.exceptions.ConfigurationException: Saved cluster name Test Cluster != configured name NixOS Test Cluster

Fixes #63388.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I deployed this to my server and my cassandra 2.2 server started up.

cc @JohnAZoidberg and committer @aanderse and maintainer @cransom

@ivan
nixos/cassandra: use cassandra's default cluster name "Test Cluster"
a476b9b 
The change to "NixOS Test Cluster" in NixOS#59179 broke startup of existing clusters
that used the previously-default cluster name "Test Cluster":

ERROR 23:00:47 Fatal exception during initialization
org.apache.cassandra.exceptions.ConfigurationException: Saved cluster name Test Cluster != configured name NixOS Test Cluster

Fixes NixOS#63388.
@aanderse
Copy link
Member

@JohnAZoidberg Please provide feedback and review.

JohnAZoidberg
JohnAZoidberg approved these changes Jun 22, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, I forgot about it.

Yeah it's fine.

@aanderse aanderse merged commit 9319216 into NixOS:master Jun 25, 2019
@aanderse
Copy link
Member

Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cassandra does not start: Saved cluster name Test Cluster != configured name NixOS Test Cluster
3 participants
@ivan @aanderse @JohnAZoidberg