Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django_taggit: fix build, enable tests #63224

Merged
merged 1 commit into from Jun 30, 2019
Merged

pythonPackages.django_taggit: fix build, enable tests #63224

merged 1 commit into from Jun 30, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 16, 2019

Motivation for this change

New django_taggit version wants django & isort at install time, enabling the tests is simple enough.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner June 16, 2019 16:49
@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 16, 2019 •
edited

@GrahamcOfBorg build pythonPackages.django_taggit python27Packages.django_taggit python36Packages.django_taggit python3Packages.django_taggit

gazally
gazally reviewed Jun 30, 2019
View reviewed changes
Copy link
Contributor

@gazally gazally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed this version for a project that I'm starting work on (which depends on wagtail which depends on django_taggit). I have successfully built the package with both the default Django and with Django 2.2, and have run the project with the 2.2 version and everything seems to be working.

@worldofpeace worldofpeace merged commit e3926c8 into NixOS:master Jun 30, 2019
@worldofpeace
Copy link
Contributor

Thanks @risicle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gazally gazally gazally left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @worldofpeace @gazally