Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: fix threejs integration #63375

Merged
merged 1 commit into from Jun 18, 2019
Merged

sage: fix threejs integration #63375

merged 1 commit into from Jun 18, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 17, 2019 •
edited

Motivation for this change

Before this it didn't find the correct files. Unfortunately, the
interactive parts of sage are hard to test automatically.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Jun 17, 2019
Merged
Closed
@timokau
sage: fix threejs integration
f2f26ac 
Before this it didn't find the correct files. Unfortunately, the
interactive parts of sage are hard to test automatically.
@timokau timokau merged commit 6e74109 into NixOS:master Jun 18, 2019
@timokau timokau deleted the sage-threejs branch June 18, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau