Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.releases: init at 1.6.1 #63237

Closed
wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Another indirect dependency of azure-cli . Sorry for the PR spam, but until #60435 gets merged, I'm just adding leaf dependencies that aren't in nixpkgs yet.

This is sphinx extension for generating changelogs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/lp5jrxlr7hbbq6inyl0sbqksr3ifpir6-python3.6-releases-1.6.1 165.4M

most of the size is sphinx ~165.2M

--replace "sphinx>=1.3,<1.8" "sphinx ~= 1.3"
'';

# Tests excluded from sdist packagen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually preferred to just use fetchFromGitHub then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that was less preferable due to the automated update bot will only look at pypi metadata.

If you want me to change, i can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-update is equipped to update this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will change then :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like he runs all his tests through another package of his called invocations, problem is that they are circular dependencies of each other, and the dependency management on invocations is.... loose. I'll just open a PR on his repo to fix the setup.py and it should be easier to package and test.

pkgs/development/python-modules/releases/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor Author

Pausing progress on this PR until I upstream some dependency fixes in targeted repos

@jonringer
Copy link
Contributor Author

A lot of the dependencies haven't been maintained in a while, and are hard to test...... I'm just going to close this. If azure-cli does need this, I'm just going to patch it out... all it helps with, is generating documentation which we don't care too much about.

@jonringer jonringer closed this Jul 30, 2019
@jonringer jonringer deleted the add_releases branch July 30, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants