Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all the elliptic functions #2206

Merged
merged 5 commits into from
Jun 16, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jun 16, 2019

I am trying to give them names that mimic the Mathematica conventions. I am also adding a bit of bibliography and some comments to each function.

Note to the reviewer: this is not a diffbase.

@@ -1378,7 +1425,7 @@ void Elbdj(double const phi,
//
// Output: elk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this comment is very helpful anymore.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it produces an elk...

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Jun 16, 2019
@pleroy pleroy merged commit 52730ea into mockingbirdnest:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants