Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gelasio: init at unstable-2018-08-13 #63273

Merged
merged 1 commit into from Aug 23, 2019
Merged

gelasio: init at unstable-2018-08-13 #63273

merged 1 commit into from Aug 23, 2019

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Jun 17, 2019 •
edited

Motivation for this change
  • package gelasio

EDIT: this is desirable because "Gelasio is a Google font that is metrically comaptible with Georgia".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

Updated the initial post to indicate that "Gelasio is a Google font that is metrically comaptible with Georgia".

worldofpeace
worldofpeace reviewed Jul 31, 2019
View reviewed changes
pkgs/data/fonts/gelasio/default.nix Outdated
version = "2018-08-12";
in fetchFromGitHub {
name = "gelasio-${version}";
owner = "SorkinType";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't align the = like this. It's not maintained in the nixpkgs tree.

@worldofpeace
Copy link
Contributor

This doesn't add the package to all-packages.nix @colemickens.

Package note should be font related as well (match commit msg).

@colemickens
Copy link
Member Author

@worldofpeace Ack on the weird alignment and all-packages.nix - I will fix and push later today.

Except, what is the "package note"? Are you saying the commit msg should note that it's a font, similar to my PR title, or something else?

@worldofpeace
Copy link
Contributor

Yeah I think I had too many synonyms in my head when i wrote that comment 🤣 .

Simple put the commit msg attribute data/fonts/gelasio isn't an actual attribute.

@colemickens
Copy link
Member Author

@worldofpeace How about the 'v' in the commit message? Is it okay version since it's not an actual release version, I feel like I've seen v<date> before in other packages? Or should I drop it?

@worldofpeace
Copy link
Contributor

@colemickens see https://nixos.org/nixpkgs/manual/#sec-package-naming

If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

It's kinda out of date for pname though, so I prepend unstable to version.
Checked awhile back and that's fine for nix-env too.

@colemickens
Copy link
Member Author

Gah, hate when I ask questions that are in the docs... thanks @worldofpeace. Will fixup soon.

@worldofpeace
Copy link
Contributor

No problem. I'm literally living nixpkgs docs future and present 😄

@colemickens colemickens changed the title data/fonts/gelasio: init at v2018-08-12 gelasio: init at unstable-2018-08-12 Aug 1, 2019
@colemickens colemickens changed the title gelasio: init at unstable-2018-08-12 gelasio: init at unstable-2018-08-13 Aug 1, 2019
@colemickens colemickens force-pushed the nixpkgs-gelasio branch 2 times, most recently from 548b813 to 55e83e7 Compare August 1, 2019 15:02
@colemickens
Copy link
Member Author

Changes made. I need to cherry-pick and test this when I have reliable wifi...

worldofpeace
worldofpeace reviewed Aug 1, 2019
View reviewed changes
pkgs/data/fonts/gelasio/default.nix Outdated
{ lib, fetchFromGitHub }:

fetchFromGitHub {
pname = "gelasio";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to revert this to what we had before, since these aren't arguments fetchFromGitHub automatically accepts.

@colemickens
Copy link
Member Author

I've been using this commit on my nixpkgs for a week, seems to work, should be safe to merge. Thanks for the guidance and reviews @worldofpeace!

@worldofpeace
Copy link
Contributor

Great @colemickens. Looks like #63273 (comment) got lost in the movements. If we fix that I can merge right away 👍

@worldofpeace worldofpeace merged commit eaf95be into NixOS:master Aug 23, 2019
@colemickens colemickens deleted the nixpkgs-gelasio branch January 30, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @worldofpeace