Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merkaartor: fix build & run #63346

Merged
merged 2 commits into from
Jun 26, 2019
Merged

merkaartor: fix build & run #63346

merged 2 commits into from
Jun 26, 2019
+8 −3

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 17, 2019

Motivation for this change

Merkaartor is not compatible with current version of Qt5 (5.12)
but is known to work with version 5.9.

Without the second patch, running merkaartor fails with the following message:
“This application failed to start because it could not find or load the Qt
platform plugin "xcb"”.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

vbgl added 2 commits June 17, 2019 16:03
@vbgl
merkaartor: fix build
e955576 
Merkaartor is not compatible with current version of Qt5 (5.12)
but is known to work with version 5.9
@vbgl
merkaartor: fix run-time loading of Qt 5 platform
462c438 
Without this patch, running merkaartor fails with the following message:
“This application failed to start because it could not find or load the Qt
platform plugin "xcb"”.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 17, 2019
@vbgl vbgl merged commit 0024cfc into NixOS:master Jun 26, 2019
@vbgl vbgl deleted the merkaartor-fix branch June 26, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl