Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.robotframework-sshlibrary: init at 3.3.0 #63415

Merged

Conversation

talkara
Copy link
Contributor

@talkara talkara commented Jun 18, 2019

Motivation for this change

Included all the fixes from the previous pull request.
#62943

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Hi @talkara, thanks for fixing this. One thing I'd would like to mention though is why you didn't force push these changes to the previous pr and branch? It's not a problem here since this looks complete, but It would be best to not duplicate in this way.

@worldofpeace worldofpeace force-pushed the pythonPackages.robotframework-sshlibrary branch from 9408819 to fe15046 Compare June 18, 2019 19:08
@worldofpeace worldofpeace merged commit 2c96ca1 into NixOS:master Jun 18, 2019
@talkara talkara deleted the pythonPackages.robotframework-sshlibrary branch September 2, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants