Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-make: 0.19.5 -> 0.20.0 #63219

Merged
merged 1 commit into from Jun 18, 2019
Merged

cargo-make: 0.19.5 -> 0.20.0 #63219

merged 1 commit into from Jun 18, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jun 16, 2019

Motivation for this change

Update cargo-make to the latest release.
https://github.com/sagiegurari/cargo-make/releases/tag/0.20.0

Note: doCheck is set as false.
Some tests fail because they need network access. However, Travis-CI ensures a proper build.
https://travis-ci.org/sagiegurari/cargo-make/jobs/546375769
https://travis-ci.org/sagiegurari/cargo-make/jobs/546375770
https://travis-ci.org/sagiegurari/cargo-make/jobs/546375771

cargo-make is a subcommand for cargo. You need to invoke cargo-make via cargo command.
To test the binary files in ./result/bin, consider the following commands:

[john@nixos:~/result/bin] PATH=.:$PATH cargo make --version
cargo-make 0.20.0
[john@nixos:~/result/bin] makers --version
makers 0.20.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented Jun 18, 2019

@GrahamcOfBorg build cargo-make

@marsam marsam merged commit ce53d94 into NixOS:master Jun 18, 2019
@marsam
Copy link
Contributor

marsam commented Jun 18, 2019

Built and tested locally on NixOS and darwin
Thanks!

@xrelkd xrelkd deleted the update/cargo-make branch June 18, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants