Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librime: 1.5.0 -> 1.5.3 #63220

Merged
merged 1 commit into from Jul 3, 2019
Merged

librime: 1.5.0 -> 1.5.3 #63220

merged 1 commit into from Jul 3, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jun 16, 2019 •
edited

Motivation for this change

Update librime to the latest release.
https://github.com/rime/librime/releases/tag/1.5.3

Note: for reviewer, it is suggested that we can use @GrahamcOfBorg build librime fcitx-engines.rime brise to build this library.

Thank you!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 17, 2019

@GrahamcOfBorg build librime fcitx-engines.rime brise

@xrelkd xrelkd changed the title librime: 1.5.0 -> 1.5.1 librime: 1.5.0 -> 1.5.2 Jun 18, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 18, 2019

@FRidh Thanks for the review, this PR has been updated again.
Please call ofborg to build it again, thank you very much!

marsam
marsam reviewed Jul 3, 2019
View reviewed changes
pkgs/development/libraries/librime/default.nix Outdated
@@ -3,13 +3,13 @@

stdenv.mkDerivation rec {
pname = "librime";
version = "1.5.0";
version = "1.5.2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.5.3 was released recently, would you mind updating it? https://github.com/rime/librime/releases/tag/1.5.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
librime has been updated to the latest release.

@xrelkd xrelkd changed the title librime: 1.5.0 -> 1.5.2 librime: 1.5.0 -> 1.5.3 Jul 3, 2019
@marsam
Copy link
Contributor

marsam commented Jul 3, 2019

@GrahamcOfBorg build librime fcitx-engines.rime brise

btw can you ask to be included in extra-known-users in https://github.com/NixOS/ofborg? so it allows you to call @GrahamcOfBorg

@xrelkd xrelkd mentioned this pull request Jul 3, 2019
Merged
@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 3, 2019

@marsam Thank you for the invitation!
It will be helpful if I could call @GrahamcOfBorg in the future.

@marsam marsam merged commit 81f15ea into NixOS:staging Jul 3, 2019
@marsam
Copy link
Contributor

marsam commented Jul 3, 2019

Thanks! tested locally on NixOS

@xrelkd xrelkd deleted the update/librime branch July 4, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @FRidh @marsam