Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erlang/OTP 22 #63296

Merged
merged 1 commit into from Jun 22, 2019
Merged

Erlang/OTP 22 #63296

merged 1 commit into from Jun 22, 2019

Conversation

ehamberg
Copy link
Contributor

@ehamberg ehamberg commented Jun 17, 2019 •
edited

This depends on #63295 being merged.

Motivation for this change

Adding the latest, stable Erlang/OTP release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehamberg ehamberg mentioned this pull request Jun 17, 2019
Closed
@cw789
Copy link
Contributor

cw789 commented Jun 18, 2019

Thank you for your PRs to add Erlang 22.

@LnL7
Copy link
Member

LnL7 commented Jun 19, 2019 •
edited

@GrahamcOfBorg build beam.packages.erlangR22.erlang beam.packages.erlangR22.elixir

@LnL7
Copy link
Member

LnL7 commented Jun 21, 2019

@GrahamcOfBorg build beam.packages.erlangR22.erlang beam.packages.erlangR22.elixir

@LnL7
Copy link
Member

LnL7 commented Jun 22, 2019

@GrahamcOfBorg build beam.packages.erlangR22.erlang beam.packages.erlangR22.elixir

LnL7
LnL7 approved these changes Jun 22, 2019
View reviewed changes
pkgs/development/interpreters/erlang/R22.nix

prePatch = ''
substituteInPlace make/configure.in --replace '`sw_vers -productVersion`' '10.10'
substituteInPlace erts/configure.in --replace '-Wl,-no_weak_imports' ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small extra fixup for the darwin build.

@LnL7 LnL7 merged commit 811f35d into NixOS:master Jun 22, 2019
@ehamberg ehamberg deleted the erlang-otp-22 branch June 22, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehamberg @cw789 @LnL7