Fix #7553: validate the number of allocated strings #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My fix was... shorter (and therefore probably incomplete), but still does not show as an error in the script debug window. PeterN@d267637 |
PeterN
approved these changes
May 1, 2019
glx22
added
the
backport requested
PeterN
pushed a commit
to PeterN/OpenTTD
that referenced
this pull request
May 2, 2019
LordAro
pushed a commit
that referenced
this pull request
May 28, 2019
LordAro
added
backported
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the crash, but the error is not reported in script debug window.
Also based on
OpenTTD/src/strings_type.h
Line 51 in 28b23a6
OpenTTD/src/game/game_text.cpp
Line 307 in 28b23a6
StringData data(32);