Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twemoji-color-font: 11.2.0 -> 12.0.1 + refactor #60742

Merged
merged 2 commits into from May 2, 2019
Merged

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented May 2, 2019

Motivation for this change

Unicode 12 \o/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Not tested since I'm on an underpowered machine and this is fairly heavy to build. Let's see what ofborg says.

@alyssais
Copy link
Member

alyssais commented May 2, 2019

Builds fine for me.

@alyssais alyssais merged commit 3e3db49 into NixOS:master May 2, 2019
@fgaz fgaz deleted the twemoji/12 branch January 20, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants