Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotests: 1.5.2 -> 1.5.3 #60738

Merged
merged 1 commit into from May 2, 2019
Merged

gotests: 1.5.2 -> 1.5.3 #60738

merged 1 commit into from May 2, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented May 2, 2019 •
edited

Motivation for this change

Bump gotests to latest version 馃懠

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
gotests: 1.5.2 -> 1.5.3
13a1c6b 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@alyssais
Copy link
Member

alyssais commented May 2, 2019

@GrahamcOfBorg build gotests

@alyssais alyssais merged commit 6e8c78e into NixOS:master May 2, 2019
@vdemeester vdemeester deleted the update-gotests branch May 2, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vdemeester @alyssais