Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg_4: 4.1.2 -> 4.1.3 #60740

Merged
merged 1 commit into from May 11, 2019
Merged

ffmpeg_4: 4.1.2 -> 4.1.3 #60740

merged 1 commit into from May 11, 2019

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 2, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@BenBals
Copy link
Contributor

BenBals commented May 2, 2019 •
edited

Build fails on Linux nixos-beb 4.19.34 #1-NixOS SMP Fri Apr 5 20:33:17 UTC 2019 x86_64 GNU/Linux:

But ffmpeg still runs. I don't know why or how.

beb@nixos-beb ~/c/nixpkgs> nix-review pr 60740
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/60740/head:refs/nix-review/1
remote: Enumerating objects: 48, done.
remote: Counting objects: 100% (36/36), done.
remote: Compressing objects: 100% (11/11), done.
Unpacking objects: 100% (18/18), done.
remote: Total 18 (delta 13), reused 9 (delta 6), pack-reused 0
From https://github.com/NixOS/nixpkgs
   cd5b868a11f..c2ac3f9f013  master               -> refs/nix-review/0
 + ac843c34bbe...cb8b3e034bb refs/pull/60740/head -> refs/nix-review/1  (forced update)
$ git worktree add /home/beb/.cache/nix-review/pr-60740/nixpkgs c2ac3f9f013f85153c435a1ac1cbd2f80acb7556
Preparing worktree (detached HEAD c2ac3f9f013)
HEAD is now at c2ac3f9f013 Merge pull request #60708 from r-ryantm/auto-update/pure-ftpd
$ nix-env -f /home/beb/.cache/nix-review/pr-60740/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit cb8b3e034bb1b753727e268a469bf9a73dcab9d4
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/beb/.cache/nix-review/pr-60740/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /home/beb/.cache/nix-review/pr-60740/build.nix
builder for '/nix/store/zm48faibs45a34rrmqr3z1mrvcgyi773-env.drv' failed with exit code 1; last 10 log lines:
  no Makefile, doing nothing
  glibPreInstallPhase
  installing
  glibPreFixupPhase
  post-installation fixup
  shrinking RPATHs of ELF executables and libraries in /nix/store/wbsiy48x8530i3l1l63mck7rhpa2f6zy-env
  strip is /nix/store/6yjpyqkx6d9k5f2s2g8h9kz40q6rz1yx-binutils-2.31.1/bin/strip
  patching script interpreter paths in /nix/store/wbsiy48x8530i3l1l63mck7rhpa2f6zy-env
  checking for references to /build/ in /nix/store/wbsiy48x8530i3l1l63mck7rhpa2f6zy-env...
  mkdir: cannot create directory '/nix/store/wbsiy48x8530i3l1l63mck7rhpa2f6zy-env': Not a directory
[31 built (1 failed), 434 copied (1104.5 MiB), 275.0 MiB DL]
error: build of '/nix/store/zm48faibs45a34rrmqr3z1mrvcgyi773-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/60740
27 package were build:
bino3d bomi curseradio deepin.deepin-movie-reborn ffmpeg_4 gnome-mpv kodi-cli lollypop mopidy-youtube mpc-qt mpv mpv-with-scripts persepolis plex-media-player pulseaudio-modules-bt python27Packages.av python27Packages.mpv python27Packages.pafy python27Packages.youtube-dl python37Packages.av python37Packages.mps-youtube python37Packages.mpv python37Packages.pafy youtubeDL sway waybar wlroots

@adisbladis
Copy link
Member Author

@GrahamcOfBorg build mpv

@adisbladis
Copy link
Member Author

@GrahamcOfBorg build mpv

vcunat
vcunat approved these changes May 11, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That error message doesn't seem really related to the version bump; I don't think we should block because of it.

vcunat added a commit to vcunat/nixpkgs that referenced this pull request May 11, 2019
@vcunat
Merge NixOS#60740: ffmpeg*: 4.1.2 -> 4.1.3
58213cd
@marsam marsam merged commit 88e5ccd into NixOS:master May 11, 2019
vcunat added a commit that referenced this pull request May 11, 2019
@vcunat
Merge #60740: ffmpeg*: 4.1.x -> 4.1.3
de0f3b9 
(cherry picked from commit 58213cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @BenBals @vcunat @marsam