Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardnotes: 3.0.6 -> 3.0.15 #60796

Merged
merged 1 commit into from Aug 10, 2019
Merged

standardnotes: 3.0.6 -> 3.0.15 #60796

merged 1 commit into from Aug 10, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 2, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/standardnotes/versions.

meta.description for standardnotes is: '"A simple and private notes app"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
standardnotes

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/p36qyc7rzi9nf8jm27xad1ypn1caz4jb-standardnotes-3.0.8 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A standardnotes https://github.com/r-ryantm/nixpkgs/archive/9f4c12b08283876804fb52b7874f6e731bb97674.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/p36qyc7rzi9nf8jm27xad1ypn1caz4jb-standardnotes-3.0.8
ls -la /nix/store/p36qyc7rzi9nf8jm27xad1ypn1caz4jb-standardnotes-3.0.8/bin

cc @M-Gregoire for testing.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 3, 2019

It builds on NixOS but when I launch it I only get a blank windows (no UI).
But then I get the same behaviour with 3.0.6 from nixpkgs stable so... This is from inside a vbox VM.

@tomberek
Copy link
Contributor

tomberek commented May 7, 2019

Ubuntu build via nix-review fails with:

Unable to read JSON file /home/dev/.config/Standard Notes/Updates/settings.json
Checking for updates...
./results/standardnotes/bin/standardnotes: line 2: 16497 Trace/breakpoint trap   (core dumped) /nix/store/52q5i9bahsf5m92cji20f5kv5kqd2xz4-appimage-run/bin/appimage-run /nix/store/p36qyc7rzi9nf8jm27xad1ypn1caz4jb-standardnotes-3.0.8/share/standardNotes.AppImage

@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 20, 2019 •
edited

The electron dev tools, if accessible, would be helpful with debugging this.

@mmahut mmahut force-pushed the auto-update/standardnotes branch 2 times, most recently from 57488de to 0fb195a Compare August 10, 2019 13:08
@mmahut mmahut changed the title standardnotes: 3.0.6 -> 3.0.8 standardnotes: 3.0.6 -> 3.0.15 Aug 10, 2019
mmahut
mmahut approved these changes Aug 10, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries, working fine

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 10, 2019 •
edited

I remember there being some PRs with @tilpner and @dtzWill that revolved somehow around this update?

But that was a while ago now, let's merge and see if that gets moving again.

@worldofpeace worldofpeace merged commit 4a3aa14 into NixOS:master Aug 10, 2019
@tilpner
Copy link
Member

tilpner commented Aug 10, 2019

@worldofpeace You're probably thinking of #54696

@worldofpeace
Copy link
Contributor

@worldofpeace You're probably thinking of #54696

Yes that is what I meant 👍

@dtzWill
Copy link
Member

dtzWill commented Aug 13, 2019

I forgot why the change wasn't made in master, but locally I've replaced 'i386' with 'i686' as I don't believe our build infrastructure will ever report hostPlatform.system as i386. Just noticed since it caused a conflict when updating to latest master containing these changes.

@r-ryantm r-ryantm deleted the auto-update/standardnotes branch August 17, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@r-ryantm @c0bw3b @tomberek @worldofpeace @tilpner @dtzWill @mmahut