Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] ham: init at (unstable-)2019-01-22 #60797

Merged
merged 7 commits into from May 2, 2019

Conversation

herrwiese
Copy link
Contributor

@herrwiese herrwiese commented May 2, 2019

Motivation for this change

This recently got into master. I'm using it on a daily basis and hence would love to also have it in stable...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@herrwiese
Copy link
Contributor Author

cc @worldofpeace

@herrwiese herrwiese changed the title Kk ham for 19.03 ham: init at (unstable-)2019-01-22 May 2, 2019
@worldofpeace worldofpeace changed the title ham: init at (unstable-)2019-01-22 [19.03] ham: init at (unstable-)2019-01-22 May 2, 2019
@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label May 2, 2019
@worldofpeace
Copy link
Contributor

I put [19.03] in the pr title because it makes it easy to see what's a backport when you can't add the label.

@herrwiese
Copy link
Contributor Author

I noted that for future cases, thanks. ;) And: Wow, that was quick.

@worldofpeace
Copy link
Contributor

I noted that for future cases, thanks. ;) And: Wow, that was quick.

Thanks, this happens to be a good time for me 😄

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport was performed correctly.

Just awaiting the ofborg checks.

@worldofpeace
Copy link
Contributor

Thanks @herrwiese

@herrwiese herrwiese deleted the kk-ham-for-19.03 branch May 2, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants