Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppl-address-book: delete #60795

Merged
merged 1 commit into from May 4, 2019
Merged

ppl-address-book: delete #60795

merged 1 commit into from May 4, 2019

Conversation

manveru
Copy link
Contributor

@manveru manveru commented May 2, 2019

Motivation for this change

This package is abandoned upstream, the website is a spam domain and the repo locked. I didn't find any active forks of it, and it has a security vulnerability in its mail dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@manveru manveru mentioned this pull request May 2, 2019
Open
27 tasks
@alyssais
Copy link
Member

alyssais commented May 3, 2019 via email

@manveru
Copy link
Contributor Author

manveru commented May 3, 2019

In case someone wants to build those gems, these are the changes they need. I found then while building variations of ppl-address-book

@manveru
Copy link
Contributor Author

manveru commented May 3, 2019

Yeah, will move it to another pr. It's here mostly so I don't forget

@alyssais alyssais merged commit 3a2be59 into NixOS:master May 4, 2019
@manveru manveru deleted the ppl-address-book-update branch May 4, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manveru @alyssais @zimbatm @c0bw3b