Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addic7ed-cli: init at 1.4.5 #60667

Merged
merged 2 commits into from May 2, 2019
Merged

addic7ed-cli: init at 1.4.5 #60667

merged 2 commits into from May 2, 2019

Conversation

eugenezastrogin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b requested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homepage is not the GH repo of the Pypi pkg you are fetching

addic7ed -> https://github.com/adrian-maurin/addic7ed
addic7ed-cli -> https://github.com/BenoitZugmeyer/addic7ed-cli/

It seems you intend to package the first one.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 1, 2019

Does the tool works for you @aethelz ?
Asking because I see the last release is from 2017 and addic7ed APIs may have changed since.

@eugenezastrogin
Copy link
Member Author

Homepage is not the GH repo of the Pypi pkg you are fetching

addic7ed -> https://github.com/adrian-maurin/addic7ed
addic7ed-cli -> https://github.com/BenoitZugmeyer/addic7ed-cli/

It seems you intend to package the first one.

Wow! Cannot believe I missed that. Sorry for the confusion.
I actually wanted to package the second one. It is newer and still works.
I made changes accordingly.

@eugenezastrogin eugenezastrogin changed the title addic7ed: init at 1.1.5 addic7ed-cli: init at 1.4.5 May 1, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 2, 2019

@GrahamcOfBorg build python27Packages.addic7ed-cli python37Packages.addic7ed-cli

@c0bw3b c0bw3b merged commit 698d4a2 into NixOS:master May 2, 2019
@eugenezastrogin eugenezastrogin mentioned this pull request May 4, 2019
Merged
@eugenezastrogin eugenezastrogin deleted the addic7ed branch May 4, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eugenezastrogin @c0bw3b